-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.11.0 #92
Release/v0.11.0 #92
Conversation
I don't think it is necessary wait for this. We can do a next release as soon as we have a fully working light client instead? |
As far as I remember that's were the only necessary changes in the repo (maybe @tarcieri has sth to add). I followed the procedure described here to publish the crate (but it's been a while). |
Good point! Yeah, let's follow all the established conventions from tendermint core where it makes sense 🎉 |
Great I opened it for review/approval! |
CHANGES.md
Outdated
- `subtle-encoding` from `0.3` to `0.5` ([#47]) | ||
- `uuid` from `0.7` to `0.8` ([#91]) | ||
- replace `rand_os` with `getrandome` ([#90]) | ||
- pin to `ed25519-dalek` `1.0.0-pre.3` ([#83]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was reverted by updating to signatory 0.17 (which now does the pinning for us). Do you still want to include it here? This is probably not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I effectively reverted that and opened an upstream issue here (which has since been fixed): dalek-cryptography/ed25519-dalek#108
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duh thanks will remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits and suggestions.
I think after https://github.com/interchainio/tendermint-rs/pull/92/files#r356883111 and https://github.com/interchainio/tendermint-rs/pull/92/files#r356883796 are addressed we are ready to go!
Co-Authored-By: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Co-Authored-By: Ismail Khoffi <Ismail.Khoffi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the last 2 commits (that invalidated the approving reviews) were only due to locally catching up with the changes from upstream (?). Still LGTM :-)
…dermint-rs into release/v0.11.0
Added everything from v0.10. Moving forward we need to enforce PRs include these themselves. Perhaps we should adopt the conventions from Tendermint Core as we're accustomed to it.
Bumped the version in the Cargo.toml and the lib.rs - anything else needed? Not sure exactly what's required in a release.
Also should we wait to include #84?